> I see some repositories using `npm run build`
najmulsheik opened this issue · comments
> I see some repositories using `npm run build`
I'd always run it with npm run build --if-present
, just like the others. This makes sure that we verify that the dependencies only used for building are tested as part of the CI
npm run validate:ts
npm run test:typescript
npm run test:ts
I'm tending towards test:tsc
to be as clear as possible. In other project I use test:tsd
for type-only tests using tsd
, and in future when I hope me move away from TS source code I could imagine @octokit to use that, too (Example)
But I'm open to anything, it's not set in stone. I do agree we should normalize it across the @octokit repositories though
Originally posted by @gr2m in octokit/.github#13 (comment)
This seems off-topic/potentially spam, closing for that reason.