octokatherine / readme.so

An online drag-and-drop editor to easily build READMEs

Home Page:https://readme.so

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bug: dark mode in preview ruins display of emoji and color

yipei1028 opened this issue · comments

Describe the bug

To Reproduce
Steps to reproduce the behavior:

  1. Go to editor
  2. Click on dark/light mode switcher
  3. See as following: Emojis display with weird filter and color code display incorrectly
    image

Expected behavior
Emojis and color code should be consistent under both dark mode and light mode.
image

Screenshots
NA

Additional context
NA

I looked into the implementation of mode switching. Using filter: invert(0.9) is handy but come with some drawbacks as describe above.

I would love to make a PR to do the enhancement. Let me know if that is possible! Thx.

@yipei1028 feel free to open a PR with a fix! thanks!

commented

Hi @octokatherine,
Just open a pull request for this issue: #281. Please take a look :)