@oclif/config should be a production dependency
ersinakinci opened this issue · comments
In https://github.com/oclif/command/blob/master/src/command.ts#L51, @oclif/config is used as part of the run method. So why is it that in package.json, it's not listed as a production dependency? Is it because it's listed as such in the main oclif package here?
The current arrangement breaks monorepo projects whose dependencies are managed by pnpm because of the way each monorepo dependency's dependencies are isolated from each other. If we could move the @oclif/config dependency out of devDependencies and into dependencies, that would be 🔥 🔥 🔥 . It's also more correct since @oclif/config is being used at runtime.
PR: #60
CC: @zkochan
Just came across this with netlify-cli. Since @oclif/config is unconditionally imported, it really needs to be either a production or a peer dependency.
Tip for all package maintainers: try installing your package with pnpm. It's the quickest way to uncover missing dependencies.
@RasPhilCo Just curious why it's a peerDependency and not a dependency.