ochotonida / artifacts

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[1.18.2] Artifacts not spawning in certain modded structures

Killahninja opened this issue · comments

Describe the bug
As the title says, it won't work in some mods, but others are fine, for example, repurposed structures' villages have the villager hat, while YUNG's Better Mineshafts doesn't have any artifacts

To Reproduce
Steps to reproduce the behavior:

  1. Have artifacts and a structure mod (I used Dungeon Crawl)
  2. Enter the config and locate Artifacts > Common and turn the rarity to 0.0
  3. Enter a world and locate a modded structure with chests in it
  4. See error

Game Environment
Please provide details about the game environment, either by crash report/logs or by detailing it below. Try to reproduce the issue without irrelevant mods first. Otherwise, include a complete list of mods or the name and version of the modpack you're using.

  • Artifacts: artifacts-1.18.2-4.2.2.jar
  • Forge: 1.18.2 [40.2.0]
  • Dungeon crawl (DungeonCrawl-1.18.2-2.3.14.jar)
  • YUNG's Better Mineshafts (Forge) [YungsBetterMineshafts-1.18.2-Forge-2.2.jar]
  • Repurposed Structures (Forge) [repurposed_structures_forge-5.1.14+1.18.2.jar]

too problem

Artifacts only adds items to vanilla loot tables. However, structures from other mods utilizing these loot tables can also contain Artifacts' items. Repurposed Structures has artifacts because it reuses vanilla loot tables for its chests, whereas YUNG's Structures and Dungeon Crawl likely have completely custom loot tables.

The items Artifacts adds are spread across various loot tables, to make exploration more diverse and to encourage players to explore in different locations. While I try to keep things (somewhat) balanced, such that any given artifact doesn't seem too common or too rare, doing this for every popular structure mod just isn't feasible.

In cases where other mods replace vanilla structures entirely with their own, I consider it their responsibility to ensure you can still find containers with the vanilla loot tables you would usually find in those structures.