[Question] Maybe we could somehow make use of react-native implementation?

Question

[Question] Maybe we could somehow make use of react-native implementation?

Szymon20000 opened this issue a year ago · comments

https://github.com/facebook/react-native/blob/f4e56fdf1946d2e54d8db7b445df001cf6ebfdb0/Libraries/WebPerformance/NativePerformance.cpp

Joel Arvidsson · Answer 1 · Wed Mar 15 2023 20:12:53 GMT+0800 (China Standard Time)

Could you elaborate a bit?

Joel Arvidsson · Answer 2 · Wed Mar 15 2023 20:14:12 GMT+0800 (China Standard Time)

Have you seen https://github.com/oblador/react-native-performance/blob/master/packages/react-native-performance/android/src/main/java/com/oblador/performance/PerformanceModule.java?

Szymon Kapała · Answer 3 · Wed Mar 15 2023 20:17:09 GMT+0800 (China Standard Time)

I just saw that someone from React Native team implemented Web Performance API. Just like you but it's a turbo module and it missing a lot of features thet your library expose. For instance Flipper plugin or a lot of native marks.
I just though that maybe this library could make use of RN implementation so it's easier for you to maintain

Joel Arvidsson · Answer 4 · Wed Mar 15 2023 20:41:34 GMT+0800 (China Standard Time)

Hmm, maybe but probably not. I have previous bad experience on relying on RN core perf stuff because it seems only FB rely on them so they break in bad ways from time to time. It looks pretty bare bones, and also it would be a breaking change for users and be tied to RN version.

Fwiw, this package is also built for new arch (one of the first packages to do so even).

Joel Arvidsson · Answer 5 · Wed Mar 15 2023 20:44:28 GMT+0800 (China Standard Time)

Are you at the conf with @mrousavy btw? Maybe we can discuss in person and would love to hear your usecases 😄

Szymon Kapała · Answer 6 · Wed Mar 15 2023 20:48:04 GMT+0800 (China Standard Time)

Unfortunately, I am tied to Poland for a few months :)
I just wanted to draw your attention to the fact that RN has partially implemented a similar thing in case it is somehow useful to you. I often use your library and it is very helpful :)