oblador / loki

👁 Visual Regression Testing for Storybook

Home Page:https://loki.js.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Loki is not supporting node 14 but lambda only runs on node 14.

thiagodmont opened this issue · comments

We are trying to update our lambdas to node16/18 but unfortunately due to a dependency in @loki/renderer-aws-lambda with chrome-aws-lambda we cannot do this.

This is the issue with the chrome-aws-lambda.

I'd like to know if there is any plans to update the @loki/renderer-aws-lambda, to use a different library for the browser.

Since loki has no support for node14 it would be great to be possible to update the node version on the lambdas as well.

I'll accept a PR migrating to @sparticuz/chromium per this guide: https://www.npmjs.com/package/@sparticuz/chromium#migration-from-chrome-aws-lambda

Great! I'm going to open the PR with the change.

Currently lambda tests are using a node 12 image from the dead lambci project, if you feel like it consider using this instead: https://github.com/aws/aws-lambda-runtime-interface-emulator

Hey @oblador I created the PR, please let me know if you have any question.