JsonRpcWebSocket doens't resend requests after reconnecting
pro-wh opened this issue · comments
What's the fate of requests that have been sent when the websocket closes due to a network error? It looks like currently their promises remain unfulfilled forever.
Details
Should JsonRpcWebSocket reject all pending requests at that time? Should it resend those requests after it reconnects?
Related: @eauge proposed that the promises should reject after some timeout.
Acceptance Criteria
@pro-wh is this popping up in the wild as a problem? If so, let's label as a P1.
theoretical. but I think we don't have analytics to detect this specifically
The more I see this the more uneasy I feel. Bumping priority.
We decided to punt this to the application layer. Closing.