oantolin / embark

Emacs Mini-Buffer Actions Rooted in Keymaps

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

org-open-at-point-global does not work on links with multiline descriptions

oantolin opened this issue · comments

As I feared, maybe Embark should use org-open-at-point when in Org buffers and org-open-at-point-global only in non-org buffers.

Maybe report this as a bug first? I think org-open-at-point-global should behave as well as org-open-at-point in Org buffers or just fall back to that?

I reported the bug and suggested your fix.

And in the meantime I'm using this workaround:

  (defun when-in-org-do-as-the-organs-do (fn)
    (if (derived-mode-p 'org-mode) (org-open-at-point) (funcall fn)))
  (advice-add 'org-open-at-point-global :around #'when-in-org-do-as-the-organs-do)

@yantar92 quickly fixed the bug now checking the entire paragraph! I think once a version of org with the fix is released, I'll update the embark org-link target finder to check the org version and, if it's new enough, use the new criterion.