GNU ELPA build of `embark-consult` includes file "embark-org.el" (which includes an outdated file)

Question

GNU ELPA build of `embark-consult` includes file "embark-org.el" (which includes an outdated file)

alphapapa opened this issue a year ago · comments

Hi Omar,

I was happy to find this fix the other day: 3ffb27a However, even after upgrading embark in my config, the problem persists.

After investigating, I find that the library embark-org is being loaded from the package embark-consult, which I have installed at v0.7 from GNU ELPA. The MELPA recipe only includes "embark-consult.el", but the GNU ELPA build includes "embark-org.el", and at a version that does not include that fix.

Thanks for your work.

Omar Antolín Camarena · Answer 1 · Wed Sep 20 2023 02:34:20 GMT+0800 (China Standard Time)

I'm afraid I don't know how to solve this. I only agreed to the GNU ELPA packages but have no idea how they actually get made.

Omar Antolín Camarena · Answer 2 · Wed Sep 20 2023 02:34:44 GMT+0800 (China Standard Time)

embark-org should be a part of the embark package, not of the embark-consult package.

Omar Antolín Camarena · Answer 3 · Wed Sep 20 2023 02:35:35 GMT+0800 (China Standard Time)

I should find out how to fix this but in the meantime, @alphapapa, I'd recommend you use MELPA for embark and embark-consult.

Daniel Mendler · Answer 4 · Wed Sep 20 2023 02:48:55 GMT+0800 (China Standard Time)

I think the issue has already been fixed on ELPA-devel. Maybe I asked one of the ELPA maintainers about it, I don't recall. It should be sufficient to bump the versions of embark and embark-consult, such that we also get updated versions on ELPA stable.

…

On 9/19/23 20:35, Omar Antolín Camarena wrote: I should find out how to fix this but in the meantime, @alphapapa <https://github.com/alphapapa>, I'd recommend you use MELPA for embark and embark-consult. — Reply to this email directly, view it on GitHub <#664 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAMMQSLT5MRA2JFGSMZMFLX3HQYDANCNFSM6AAAAAA46VLRXE>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Daniel Mendler · Answer 5 · Wed Sep 20 2023 02:51:08 GMT+0800 (China Standard Time)

See https://git.savannah.gnu.org/cgit/emacs/elpa.git/commit/elpa-packages?id=0d9c026a16afee10529ea42a98218693e39a8c82

…

On 9/19/23 20:48, Daniel Mendler wrote: I think the issue has already been fixed on ELPA-devel. Maybe I asked one of the ELPA maintainers about it, I don't recall. It should be sufficient to bump the versions of embark and embark-consult, such that we also get updated versions on ELPA stable. On 9/19/23 20:35, Omar Antolín Camarena wrote: > I should find out how to fix this but in the meantime, @alphapapa > <https://github.com/alphapapa>, I'd recommend you use MELPA for embark > and embark-consult. > > — > Reply to this email directly, view it on GitHub > <#664 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAMMQSLT5MRA2JFGSMZMFLX3HQYDANCNFSM6AAAAAA46VLRXE>. > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> >

Omar Antolín Camarena · Answer 6 · Wed Sep 20 2023 02:52:16 GMT+0800 (China Standard Time)

Looking into it, I think this file is what decides what each package contains, and indeed, it seems to be fixed already:

 (embark		:url "https://github.com/oantolin/embark"
  :doc "embark.texi"
  :ignored-files ("embark-consult.el" "avy-embark-collect.el"))
 (embark-consult	:url "https://github.com/oantolin/embark"
  :ignored-files ("embark.el" "embark.texi" "avy-embark-collect.el"
                  "embark-org.el"))
``

Omar Antolín Camarena · Answer 7 · Wed Sep 20 2023 02:52:50 GMT+0800 (China Standard Time)

Oh, @minad as usual beat me to the punch and even quoted the exact commit that fixed it.

Omar Antolín Camarena · Answer 8 · Wed Sep 20 2023 02:53:26 GMT+0800 (China Standard Time)

OK. Will bump versions, then.

Omar Antolín Camarena · Answer 9 · Wed Sep 20 2023 02:55:45 GMT+0800 (China Standard Time)

By the way, shouldn't I just remove avy-embark-collect? It's not in any package, except possibly by mistake, and I sincerely hope no-one is using it...

Daniel Mendler · Answer 10 · Wed Sep 20 2023 03:00:47 GMT+0800 (China Standard Time)

On 9/19/23 20:55, Omar Antolín Camarena wrote: By the way, shouldn't I just remove |avy-embark-collect|? It's not in any package, except possibly by mistake, and I sincerely hope no-one is using it...

It is available on MELPA (~600 downloads), so it should stay here, unless you want to deprecate it and stop maintaining it. I don't use it, never have, so I wouldn't mind. But there seem to be a few users at least.

Omar Antolín Camarena · Answer 11 · Wed Sep 20 2023 03:04:39 GMT+0800 (China Standard Time)

It is available on MELPA (~600 downloads)

I'm so clueless! 😄 I must have known this, because I must have submitted it, but honestly did not remember. Maybe I should at some point officially deprecate it in favor of link-hint.

Daniel Mendler · Answer 12 · Wed Sep 20 2023 03:11:49 GMT+0800 (China Standard Time)

On 9/19/23 21:04, Omar Antolín Camarena wrote: It is available on MELPA (~600 downloads) I'm so clueless! 😄 I must have known this, because I must have submitted it, but honestly did not remember. Maybe I should at some point officially deprecate it in favor |link-hint|.

Haha, indeed you did melpa/melpa#7359. Regarding link-hint, I remember there were some technical problems which prevented you from going forward with the avy-embark-collect deprecation. Do you still use avy-embark-collect? If not you could also move it to a separate repository for preservation and ping the MELPA maintainers to drop it from the archive. 600 downloads is not much. I personally try to avoid packages which have fewer than maybe 5k or 10k downloads, except if I am happy to hack on the package myself. But some of my lesser known packages don't even reach these threshold yet.

Omar Antolín Camarena · Answer 13 · Wed Sep 20 2023 03:17:29 GMT+0800 (China Standard Time)

I don't remember what the problem with link-hint was. It is what I use now instead of avy-embark-collect.

Omar Antolín Camarena · Answer 14 · Wed Sep 20 2023 03:19:36 GMT+0800 (China Standard Time)

I hope the GNU ELPA fix + the version bump here takes care of this, so I'm closing.

Omar Antolín Camarena · Answer 15 · Wed Sep 27 2023 22:32:00 GMT+0800 (China Standard Time)

@minad: I remembered what my problem with link-hint was, noctuid/link-hint.el#219