oae / gnome-shell-extensions-sync

Syncs gnome shell keybindings, tweaks settings and extensions with their configuration across all gnome installations

Home Page:https://extensions.gnome.org/extension/1486/extensions-sync/

Repository from Github https://github.comoae/gnome-shell-extensions-syncRepository from Github https://github.comoae/gnome-shell-extensions-sync

Remove Array.prototype.diff prototype augmentation

GeeWee opened this issue · comments

In sync.js we're augmenting array with Array.prototype.diff
This can break other extensions looping over arrays (see e.g. gTile/gTile#22 (comment))

I think it would be best to remove the prototype augmentation, it's widely considered a bad idea in environments where code have to share a runtime.

thank you for the feedback. I have removed it and will release it in the next version

Awesome! Thanks!