o2r-project / o2r-shipper

Export research compendia to repositories and archives

Home Page:https://o2r.info/results/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

make host settings configurable for custom repositories

opened this issue · comments

i.e. not in the class file but in config so to keep the IP of repository hidden

use case: custom archivematica installation serves as repository endpoint

idea:

add it to config file json e.g.

{
 "my_host": "1.2.3.4"
}

and in the repo class signal that it uses config to define the host:

 def __init__(self):
        self.HOST = "my_host"
        self.USECONFIG = True
        self.LABEL = "Archivematica local"
        self.ID = 'archivematica'

Or should the class files for each repo be more than templates, e.g. include the full definition for each service?

  • repoarchivematica_local.py
  • repozenodo.py
  • repozenodosandbox.py
  • repozenodosandbox_local.py
    ...

but then the config properties would be included in this gh repo

discarded after careful consideration