o1-labs / o1js

TypeScript framework for zk-SNARKs and zkApps

Home Page:https://docs.minaprotocol.com/en/zkapps/how-to-write-a-zkapp

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove the `string` argument from mina-signer's `signTransaction`

mitschabaude opened this issue · comments

This is extremely easy to misuse by passing in a stringified transaction. Also, it's misleading, because with the string argument it will just do signMessage() which is not a function intended for signing transactions.

Another idea, maybe we should remove signMessage() altogether or replace it with a signFields()-compatible signing algorithm?