Giters

nyx-space / anise

ANISE provides a toolkit and files for Attitude, Navigation, Instrument, Spacecraft, and Ephemeris data. It's a modern replacement of the NAIF SPICE toolkit.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Context must be able to load all data types directly

ChristopherRabotin opened this issue · comments

commented

High level description

Requirements

  • DataSet needs the bytes to loaded manually and must outlive the DataSet itself. This will likely require changing from &[u8] to Bytes, but there are likely lifetime issues to resolve there. Might be worth seeing if there's a solution by upgrading to the latest der version.
  • Context must be able to load the data directly instead of requiring the SPK and BPC to be loaded manually and then inserted into the context.

Test plans

How do we test that these requirements are fulfilled correctly? What are some edge cases we should be aware of when developing the test code.

Design

TBD

Algorithm demonstration

No change.

API definition

This will likely require changing the load_spk to include_spk and change the behavior of load_spk to be behind std only and load from a file path.

High level architecture

No significant change I think.

Detailed design

The detailed design *will be used in the documentation of how ANISE works.

Feel free to fill out additional QA sections here, but these will typically be determined during the development, including the release in which this issue will be tackled.

commented

Implemented in 09acd94 but I'm afraid that it won't work once we try to load the Dataset file from the heap. That's an issue that prevents it from working with DAF, and forces the data to be copied to the heap.