Giters

nytimes / openapi2proto

A tool for generating Protobuf v3 schemas and gRPC service definitions from OpenAPI specifications

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Invalid protobuf files in fixtures/

curiousleo opened this issue · comments

commented

protoc v3.7.1 throws errors when parsing fixtures/accountv1-0.proto:

$ protoc --version
libprotoc 3.7.1
$ protoc -o/dev/null fixtures/accountv1-0.proto
fixtures/accountv1-0.proto:342:14: "Permissions" is already defined in "accountinformationapis.AccountRequest.DataMessage".
fixtures/accountv1-0.proto:646:14: "Permissions" is already defined in "accountinformationapis.CreateAccountRequest.DataMessage".
fixtures/accountv1-0.proto:362:18: "Permissions" is not defined.
fixtures/accountv1-0.proto:672:18: "Permissions" is not defined.
fixtures/accountv1-0.proto:1004:68: "CreateAccountRequest" is not a message type.
fixtures/accountv1-0.proto:1014:20: "GetAccountRequest" is not a message type.
fixtures/accountv1-0.proto:1039:62: "CreateAccountRequest" is not a message type.
$ echo $?
1
commented

books.proto is also incomplete:

books.proto:361:26: "GETReviewsFormatRequest" is not defined.
books.proto:361:60: "GETReviewsFormatResponse" is not defined.
commented

kubernetes.proto has over a thousand "... is not defined" errors.

Note: the updated kubernetes.proto in #129 passes protoc validation.