Maximum size of memory cache is by default 1
saket opened this issue · comments
MemoryPolicyBuilder defaults to 1 as the max-size. Is this a mistake? Or does this get overridden somewhere else?
You can pass in a new Max-Size in the builder https://github.com/NYTimes/Store/blob/feature/rx2/store/src/test/java/com/nytimes/android/external/store3/base/impl/MemoryPolicyBuilderTest.java#L55
True, but when a MemoryPolicy is built with an expiry policy, the max-size defaults to 1 unless specified by the user:
That seems like a bug. Want to pr a fix?
Sure. What value should we default to?
@pavlospt offered to get the fix in. If no progress in few days I'll ping you 🙂
Great find btw! I guess I just always set all the policy flags explicitly in personal use.
Hey @digitalbuddha & @Saketme, I opened a PR #328. LMK if this is ok or you need any other modifications!
Oh nice. Thanks @pavlospt!
#328 Merged, closing issue