Xcode 12 build fails due to PINCache error
opened this issue · comments
I know this is not properly a NYTPhotoViewer issue but, since it uses that library, it is unable to build in Xcode 12 since PINCache fails.
I also have the same issue with Xcode 12 Beta 4
2 compilation errors for me:
Pods/PINCache/Source/PINCache.m:121:62: error: incompatible block pointer types sending 'void (^)(PINMemoryCache *__strong, NSString *__strong, __strong id)' to parameter of type 'PINCacheObjectBlock _Nonnull' (aka 'void (^)(id _Nonnull __strong, NSString * _Nonnull __strong, id _Nullable __strong)')
[self->_memoryCache objectForKeyAsync:key completion:^(PINMemoryCache *memoryCache, NSString *memoryCacheKey, id memoryCacheObject) {
Pods/PINCache/Source/PINCache.m:274:64: error: incompatible block pointer types sending 'void (^)(PINDiskCache *__strong)' to parameter of type 'PINCacheBlock _Nonnull' (aka 'void (^)(id _Nonnull __strong)')
[_diskCache synchronouslyLockFileAccessWhileExecutingBlock:^(PINDiskCache *diskCache) {
PINRemoteImage just released a new version that fixed the issue. @mr-fixit I saw you on the PINRemoteImage issue, I assume we just need to update the dependency and this issue will be gone, right? I'd love to try this myself but I'm not familiar with Carthage.
There you go #324
I'm still having this issue with the new Xcode 12 GM seed. I simply have pod 'NYTPhotoViewer' in my Podfile and it fails to build because it still keeps installing the old PINCache (3.0.1-beta.8) from 2019 instead of the new 3.0.1 release.
on it!
this will be fixed by PR #330
fixed in 5.0.4