nytimes / NYTPhotoViewer

A modern photo viewing experience for iOS.

Home Page:http://open.blogs.nytimes.com/2015/03/27/a-new-view-for-nytimes-photos/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

If status bar un-hidden by subclassed `NYTPhotosViewController` variant (in order to avoid distorting other view controllers by hiding status bar during animation to/from modal), `NYTPhotosOverlayView` underlaps system status bar.

benguild opened this issue · comments

This has been addressed by #221 and somewhat repaired by the comments and changes that I suggested on that PR, but I just wanted to bring it up.

Since NYTPhotosOverlayView isn't a view controller or navigation controller, it doesn't get the status bar indent "for free" as other views would.

However, by hiding the status bar on this modal entirely, it can negatively affect other views underneath.

It seems quite natural to me to have an option to retain the status bar as it looks fine when set to "light content" mode, although debatably visually distracting.