nxt3AT / sankeydiagram.net

sankeydiagram.net is an easy-to-use webapp for generating Sankey Diagrams to visualize flows and budgets.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

dev experience feature request: add eslint and prettier to project

domvo opened this issue · comments

commented
commented

I've added eslint in the dev branch. I've also tried out prettier but I think their default style is really weird/redundant.

i.E.:

document
  .querySelector(".export-txt-button")
  .addEventListener("click", downloadCurrentInputAsTxt);
document
  .querySelector("#import-text-input")
  .addEventListener("change", handleFileImport);

value: sankeyHideZerosSetting.checked
  ? Number(parseFloat(value).toFixed(precision))
  : parseFloat(value).toFixed(precision),

if (
  d.outgoing.length > 0 &&
  d.incoming.length > 0 &&
  Math.abs(outgoingValue) !== Math.abs(incomingValue)
) {

Are there any config recommendations for it? 😅

commented

I will close this issue due to having added eslint to the project already and it looks like that's good enough. Feel free to open other issues if there should be added / configured something else.