nxhack / openwrt-node-packages

Package ninja becomes host only since upstream commit openwrt/packages@4e740b2.
However on openwrt-21.02 branch it is still packaged, and causes the following error:

Fulllog could be found here: https://downloads.immortalwrt.org/releases/faillogs-21.02/arm_cortex-a7_neon-vfpv4/packages/node-aws-crt/compile.txt

info TOOL Using Ninja generator, because ninja is available.
info TOOL Building only the install target, as specified from the command line.
info CMD CONFIGURE
null  
info TOOL Building only the install target, as specified from the command line.
info RUN [
info RUN   'cmake',
info RUN   '/immortalwrt/openwrt-21.02/build_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/node-aws-crt-1.12.0',
info RUN   '--no-warn-unused-cli',
info RUN   '-G',
info RUN   'Ninja',
--- cut ---
Not searching for unused variables given on the command line.
CMake Error at CMakeLists.txt:2 (project):
  Running

   '/immortalwrt/openwrt-21.02/staging_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/root-bcm27xx/usr/bin/ninja' '--version'

  failed with:

   /immortalwrt/openwrt-21.02/staging_dir/target-arm_cortex-a7+neon-vfpv4_musl_eabi/root-bcm27xx/usr/bin/ninja: 1: Syntax error: word unexpected (expecting ")")

ninja in SYSROOT is for the target device and obviously cannot be executed by current system.
I'm not familiar with CMake so it would be best if you can take a look. Thanks so much!

openwrt-node-packages/node-aws-crt/Makefile

Line 26 in c2c9e5a

PKG_USE_NINJA:=0

btw, PKG_USE_NINJA is not defined on 21.02 branch.

You are certainly correct in your point. I didn't realize that my environment had ninja in the host OS.
I will think about it a little.

[openwrt-21.02] Failed to build node-aws-crt when ninja is installed