nwolverson / vscode-language-purescript

PureScript Language Support for Visual Studio Code

Home Page:https://marketplace.visualstudio.com/items/nwolverson.language-purescript

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bracket Pair Colorizing is happening and in wrong places

eikooc opened this issue · comments

Issue Type: Bug

VSCode recently introduced fast bracket pair colorization. This leads to wrong and slow colorization in Purescript files. It seems to be tied to infixing for example with shouldEqual.

image

Extension version: 0.2.5
VS Code version: Code 1.61.2 (6cba118ac49a1b88332f312a8f67186f7f3c1643, 2021-10-19T15:49:28.381Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No
Fetching remote diagnostics for 'ssh-remote' timed out.

System Info
Item Value
CPUs Apple M1 (8 x 24)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 16.00GB (0.05GB free)
Process Argv --crash-reporter-id 6c5c31e9-6fe1-4a3e-8d95-07bef60a96f1
Screen Reader no
VM 0%

Fetching remote diagnostics for 'ssh-remote' timed out.

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscorecescf:30384386
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
vsccppwtct:30382698
pythonvssor306:30344512
bridge0708:30335490
pygetstartedt3:30385195
dockerwalkthru:30377721
bridge0723:30353136
pythonrunftest32:30373476
pythonf5test824:30373475
javagetstartedt:30364666
pythonvspyt187:30373474
vsqsis200cf:30386380
vsaa593cf:30376535
vssld246:30386377

Not sure why we have this in the brackets definition

		["\"", "\""],
		["`", "`"]

I wonder if that is a relic of before the distinction of surroundingPairs etc https://code.visualstudio.com/api/language-extensions/language-configuration-guide

I've noticed vscode is angry about " recently, must be the same reason.

Fixed in 59772a1 & released