nwjs / grunt-nw-builder

Build NW.js applications for Mac, Windows and Linux using Grunt

Home Page:https://www.npmjs.com/package/grunt-nw-builder

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add option to change windows executable icon using node-rcedit

SamyPesse opened this issue · comments

I think it could be cool to have a "win_ico" option to define icon for windows executable using: https://github.com/atom/node-rcedit

I'v been looking for a way to implement this! As far as I can see this is windows only? There is a discussion in how to implement this on all plattforms in #11

Do you know a way to get this working on a mac or an linux?

I'll probably do a PR on node-rcedit to support wine for linux and mac since it uses the rcedit.exe.

Do you think it could be a good solution for mac/linux (users will have to install wine)?

I'll do a PR on this repo after if you're ok with that.

If you do a PR, please do it in https://github.com/mllrsohn/node-webkit-builder - I think having support for windows on windows is better than nothing.

Ok great, I'll first add support for wine on node-rcedit and then do a pr on node-webkit-builder.