Create an independent npm module out of it
steffenmllr opened this issue · comments
As I want to support gulp and grunt, it would make sense to port the builder into a separate npm module and only make a wrapper for grunt and gulp -> https://github.com/mllrsohn/node-webkit-builder
👍
👍👍
👍
What's the progress on this? Does node-webkit-builder have parity yet?
I may be able to help out with this. What needs to be done?
@feross have a look at the repo / tests. one prob is that the "get-latest-version" stuff doesn't work anymore (because nw isn't hosted on aws anymore), the cli stuff is missing and that's about it - the rest should work.
@feross Are you sure about nw not being hosted in aws?
I don't know the status of nw 14 days ago, but it is hosted now.
This is taken from nodewebkit's install.js script, and tested on windows:
// Determine download url
if (process.platform === 'darwin') {
url = 'http://s3.amazonaws.com/node-webkit/v' + version + '/node-webkit-v' + version + '-osx-ia32.zip';
} else if (process.platform === 'win32') {
url = 'http://s3.amazonaws.com/node-webkit/v' + version + '/node-webkit-v' + version + '-win-ia32.zip';
} else if (process.arch === 'ia32') {
url = 'http://s3.amazonaws.com/node-webkit/v' + version + '/node-webkit-v' + version + '-linux-ia32.tar.gz';
} else if (process.arch === 'x64') {
url = 'http://s3.amazonaws.com/node-webkit/v' + version + '/node-webkit-v' + version + '-linux-x64.tar.gz';
}
nw was hostet on aws - it's not anymore - so the auto-get-newest-version needs some work. Maybe ask rogerwang in #68 if he could provide a json with the dir list or maybe parse the github release api...
The install script I posted successfully downloads nw binaries. Tested on win7
http://s3.amazonaws.com/node-webkit/v0.9.2/node-webkit-v0.9.2-linux-x64.tar.gz
Downloads just fine
hmm we should ask rogerwang if it's ok to use the aws link
I think there shouldn't be any problems.. Its the same he uses for npm
install nodewebkit
El abr 10, 2014 6:36 PM, "Steffen Müller" notifications@github.com
escribió:
hmm we should ask rogerwang if it's ok to use the aws link
Reply to this email directly or view it on GitHubhttps://github.com//issues/46#issuecomment-40146025
.
There is also still some stuff left to at: https://github.com/mllrsohn/node-webkit-builder
- the cli stuff
- testing
I'm pretty full the next weeks with client work so any help is appreciated :)
Ok, I'll try to help :)
There you go: https://github.com/mllrsohn/node-webkit-builder
There might be some bug, so some feedback would be nice :)
@adam-lynch you can get rid of grunt now - would be great if you could test the first version
@steffenmllr Great! I'll test this when I get a chance. What kind of bugs should I look out for?
make sure it works on linux and windows
make sure you install with npm install mllrsohn/node-webkit-builderto get the latest version from github, I'll try to get a code coverage tool to see where the bilnd spots are.
What''s the status of this?
I'd love to help with a brunch version, too, using the same lib.
@konsumer pls check: https://github.com/mllrsohn/node-webkit-builder there is one bug in the linux build everything else should work I don't really have a lot of time atm so help is appreciated
