Windows icon not working
mcgraphix opened this issue · comments
Using the following configuration results in the application having the default nw icon:
nodewebkit: {
options: {
platforms: ['win','osx'],
buildDir: './webkitbuilds',
winIco: './my-logo.ico'
},
src: ['./build/*/']
}
I saw that there is another issue with Mac icons (#106) but I'm not sure if they are connected. I haven't tried on a mac but removing 'osx' from the platforms array doesn't make any difference in my case.
I'm using:
grunt-node-webkit-builder: 1.0.0
node-webkit: 0.11.0-rc1 (on windows)
Could you go into node_modules/grunt-node-webkit-builder/node_modules/node-webkit-builder/package.json and tell me what the version is?
It is "1.0.0"
Ok. Open the command-line in node_modules/grunt-node-webkit-builder, run npm install node-webkit-builder@1.0.2 and try again, please
We're aware of problems with versions since version 1.0.0, just try 1.0.2 and see if it suits you. Chances are it could break something else. Wouldn't mind knowing what the result is for you though. We're working on the bugs anyway.
Ok. That is a step in the right direction. The resulting exe file has the correct icon now. But, when you launch it, the taskbar icon and the icon in the top left of the window next to the application name is still the default icon.
That's not happening for me. It might just be cache or something. Closing this in favour of nwutils/nw-builder#142.
I've just published node-webkit-builder@1.0.3 with what was on that fixing-1.0.x branch and another small fix. So if you delete grunt-node-webkit-builder, run npm cache clean and then npm install, you should get grunt-node-webkit-builder with node-webkit-builder@1.0.3 as a dependency
Still no luck for me. Though it looks like I'm getting node-webkit-builder@1.0.4
The other thing I noticed was that although the file icon looks correct, the icon in the details panel at the bottom of windows explorer is incorrect. See the attached screenshot. I don't know much about icons so I'm not sure how that happens as I thought it would use the same actual .ico file
That happens for me too. That might be a node-webkit bug or windows
explorer cache.
On Mon, 22 Dec 2014 14:41 mcgraphix notifications@github.com wrote:
Still no luck for me. Though it looks like I'm getting
node-webkit-builder@1.0.4The other thing I noticed was that although the file icon looks correct,
the icon in the details panel at the bottom of windows explorer is
incorrect. See the attached screenshot. I don't know much about icons so
I'm not sure how that happens as I thought it would use the same actual
.ico file[image: image]
https://cloud.githubusercontent.com/assets/1789874/5526172/9a14e812-89be-11e4-8826-4d0d71d0f07e.png—
Reply to this email directly or view it on GitHub
#124 (comment)
.
Hmmm... That isn't the main issue though since I can build an installer with Inno Setup. With that, the icon in the taskbar seems to be correct, presumably because of the way the installer script is and shortcut is created. However, if after installing, I go into the program files and actually look at the exe file, its icon is correct, but the detail panel is still wrong.
That said, the only part that is really a big deal (relatively speaking), is the icon in the title bar when the app is running. If I could get that to work, I wouldn't really care that much about the others.