Having problem with the popup close

[realAudi]

Originally when I tried this module, I was getting a behaviour where after LinkedIn authorized, my return URL would render in the popup, rather than close and pass back the token. Then at one point it just started to work properly. Then I compiled and it went back to the original behaviour of not closing the popup.
I have embedded

the component in my own page (coverpage). And for debugging purposes taken your code and put it under my utilis folder, just so I can add console.log debugs and figure out whats going on.
I think it's in the eventlistener attachment, as I cannot see any of these events registered in the tools window attached to the document of the popup. But I am not sure. It could also have something todo with the browser router as I am embedding it in another page... I am not quite certain what the intent of the router is here.
Below you can see the code for the relevant files. let me know if you need anything else.
T
linkedin_debugging.zip
hanks- I have been pulling my hair out for 2 days on this.

[realAudi]

oh sorry I forgot. You can look at the app at
ayda.io:8080
although here I have changed the popup to be "parent" just to get it to pass back to me the auth code and proceed

[Hung Viet Nguyen]

Hey @realAudi
Sorry but I haven't gotten your problem.
I tried on ayda.io:8080 but what I got back after successfully authorized is that I am redirected to your localhost:3000
Can you specify your problem you are facing a little bit clearer. If there is a video attached, it would be very helpful.
Thanks.

[realAudi]

Oh sorry I uploaded something yesterday and forgot I had hard coded the redirect. Will fix this afternoon and notify. Basically the problem I have is that once the pop up is rendered and you auth with LI, the redirect renders in the popup not the parent (for now I have set the window open to parent not blank, just to allow me to continue. But I will set it back to your code when I redeploy this afternoon) I think the problem may be attaching the event monitor to the popup widow. When I inspect the events on the popup window and the parent using chrome tools, I don’t see the one from your module, at least not at the document level. Or should it be somewhere else? Therefore on auth the window does not get closed, and the parent receive the key.

…

Sent from my iPad

On 16 Nov 2018, at 10:07, Hung Viet Nguyen ***@***.***> wrote: Hey @realAudi Sorry but I haven't gotten your problem. I tried on ayda.io:8080 but what I got back after successfully authorized is that I am redirected to your localhost:3000 Can you specify your problem you are facing a little bit clearer. If there is a video attached, it would be very helpful. Thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[realAudi]

OK I have uploaded the new build, using your module directly. Redirect is fixed. You will see after auth the app is loaded in the popup and not the parent window. Thanks for your help and responding quickly. Audi

…

On 16. Nov 2018, at 10:52, Audi Lucas ***@***.***> wrote: Oh sorry I uploaded something yesterday and forgot I had hard coded the redirect. Will fix this afternoon and notify. Basically the problem I have is that once the pop up is rendered and you auth with LI, the redirect renders in the popup not the parent (for now I have set the window open to parent not blank, just to allow me to continue. But I will set it back to your code when I redeploy this afternoon) I think the problem may be attaching the event monitor to the popup widow. When I inspect the events on the popup window and the parent using chrome tools, I don’t see the one from your module, at least not at the document level. Or should it be somewhere else? Therefore on auth the window does not get closed, and the parent receive the key. Sent from my iPad On 16 Nov 2018, at 10:07, Hung Viet Nguyen ***@***.*** ***@***.***>> wrote: > Hey @realAudi <https://github.com/realAudi> > Sorry but I haven't gotten your problem. > I tried on ayda.io:8080 <http://ayda.io:8080/> but what I got back after successfully authorized is that I am redirected to your localhost:3000 > Can you specify your problem you are facing a little bit clearer. If there is a video attached, it would be very helpful. > Thanks. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AnNhncSpTwxVuSOv3X9RjROdPRxRxc2iks5uvoBigaJpZM4YeHkM>. >

[Hung Viet Nguyen]

@realAudi
Hey, I looked into your source code and I see what is the problem here.
I think that you are not redirected in parent window because you pass the wrong URI in redirectUri
I think with your source code, you should pass

redirectUri={`${window.location.origin}/linkedin`}

Let me explain a little bit what we will do here.
When you include <LinkedIn />, I put an event listener here.
After authorized, the popup window will redirect to /linkedin (still in popup window), then from here, it will emit an event to parent window that it is successfully authorized and close the current popup window in the same time. (/linkedin should route to LinkedInPopUp in react-linkedin-login-oauth2)
I think that the example I wrote maybe confuse you a bit. Please let me know if you can fix that or you need more help from me.

Regards.

[realAudi]

Ah ok now I see how you are doing it. Nice trick attaching the event listener to the popup and redirecting back to the popup. Works now, thanks very much for your help.

…

On 18. Nov 2018, at 04:16, Hung Viet Nguyen ***@***.***> wrote: @realAudi <https://github.com/realAudi> Hey, I looked into your source code and I see what is the problem here. I think that you are not redirected in parent window because you pass the wrong URI in redirectUri I think with your source code, you should pass redirectUri={`${window.location.origin}/linkedin`} Let me explain a little bit what we will do here. When you include <LinkedIn />, I put an event listener here. After authorized, the popup window will redirect to /linkedin (still in popup window), then from here, it will emit an event to parent window that it is successfully authorized and close the current popup window in the same time. I think that the example I wrote maybe confuse you a bit. Please let me know if you can fix that or you need more help from me. Regards. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AnNhnT-0EjDRnf2MVo3nDsKs3IuQRJ_Uks5uwND5gaJpZM4YeHkM>.

[Hung Viet Nguyen]

@realAudi My pleasure. Let me know if you need any help.
Thanks.

[Deleted user]

Event Listener is not working in redux form.