Giters

nurupo / vlc-pause-click-plugin

Plugin for VLC that pauses/plays video on mouse click

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Plugin crashes VLC (green picture) on playing next udp multicast stream

popy2k14 opened this issue · comments

commented
Self-troubleshooting
Software

OS: Windows 10 x64 Build 1903 with all Updates
VLC version: 3.0.8 & 3.0.7.1
VLC bitness: 64
Plugin version: 2.1.0 (latest)
Plugin bitness: 64

Issue description

With plugin activated:
I am opening VLC and load an playlist.m3u (see attachment).
This playlist just has some udp multicast streams in it.
The first plays well, but when i am pressing "next" at the bottom,
the stream loads somehow and audio is working, but the picture is just green!

With plugin deactivated:
All is working like it should.

Can you please look into the issue?
Is there anything i can help, logs...?
`
thx

playlist.zip

commented

Which OS is that? You kept the "Windows / Linux / macOS" placeholder text.

commented

Sorry, added the info in the OP.

commented

Ok, will test it later this week.

Can't think of why it would make the picture green off the top of my head.
Does the same happen when you use spacebar to pause/play?

commented

Does the same happen when you use spacebar to pause/play?

Sorry, missed that you don't even pause, you just go to the next item in the playlist.

I have tried to reproduce the issue, but I'm unable to connect to the 239.200.199.x addresses in the playlist. These are multicast addresses, they are accessible to you due to the services you use. I don't have any multicast services, so VLC simply fails to connect to them. So I'm unable to reproduce the issue.

commented

Hi @nurupo I ran into the same problem recently and it keeps reproduced for several days.
Here is the only scenario how can I reproduce this problem:

  1. Add several videos to the playlist
  2. Play first video
  3. Wait until player switches to another video
  4. See green screen but audio is still ok.

So this cannot be reproduced when just playing a video or pause/play it.
It 100% reproduced when player switches to next video in the playlist.
Also toggling checkbox "Pause/Play video on mouse click" in [Advanced -> Video -> Filters] affects this. Problems is not reproduced when checkbox is off but is exists when checkbox is on.

Here is my configuration:

  • Windows 10 x64 version 1909
  • VLC 3.0.8
  • Plugin vlc-3.0-64bit-win.zip

Also I reinstalled VLC, downloaded the plugin again from releases page and copied dll file to video_filter again. Nothing helped.

commented

Also I reinstalled VLC, downloaded the plugin again from releases page and copied dll file to video_filter again. Nothing helped.

Could you try manually deleting the whole %AppData%\vlc directory too? It's possible that the VLC uninstaller could keep VLC settings in there just in case you would install it back later.

commented

Just to make it clear, in your reproduction steps, you never clicked on the video image to pause it? You can add several videos in the playlist, play the first one, not touch mouse and keyboard, and it's still reproducible?

Also, do you have any non-default settings set? Like a different video output module or any extra video filters you are enabling?

commented

Also, could you provide the logs of your reproduction? Someone has pointed out that it could be a decoding issue of sorts, which could appear in the logs.

vlc.exe -vv --logfile=c:\vlclog.txt
commented

@nurupo
I tried with clicking the video image and without doing this. In both cases I saw green screen once VLC switched to next video.
Also I tried to reset all settings, then setup the plugin as described in documentation. The problem is still reproduced.
But I noticed that not all the videos can reproduce this. I tried a lot of videos, some of them work, some not. Don't know why - maybe depend of how they encoded or so.
https://www.dropbox.com/sh/o8xcrrruacr2l37/AAC6FUVAYpqM19oq1ZPD4f7ha?dl=0 - here are link on a shared dropbox folder that contains two videos - I managed to always reproduce the problem with those 2 videos. Here is how I recently reproduced:

  1. Install fresh VLC player with resetting preferences
  2. Follow instructions to install the plugin
  3. Restart VLC
  4. Add two videos ("domovenok_1", "domovenok_2" to the playlist)
  5. Double-click first video on playlist
  6. Wait until it finished
  7. Then VLC started second video and shown me green screen. Video is going but nothing shown but just a green frame.

Also I tried to not wait in the step "6" but just scroll to the very end of the video. The same result: video finished and new video started - and nothing but green frame. So it doesn't depend whether I interact with any controls with mouse/keyboard.

Here are logs. I used the same videos that I attached above. I enabled log file in advanced preferences. Every time I renamed log file and let new log file be created.

With pauseclick - green screen (scrolled to the end and wait for switch to the next video)
With pauseclick - green screen (didn't do anything, just waited until first video ended and next video started)
Without pauseclick - ok

commented

Couldn't reproduce with the provided video files and I don't see anything suspicious in the logs. Have no idea why your are having this issue.

Logs say that VLC is using d3d11va hardware decoder module and Nvidia drivers - it could be something related to those, but that's just a guess. My system has only Sandy Bridge Intel integrated graphics and it doesn't support d3d11, so when I use VLC it uses something different for hardware decoding, which might be why I don't have the issue.

commented

Good news: reproduced on someone else's computer. Couldn't debug it, but there are a couple of workarounds I have figured out with some trial and error:

  1. Disable hardware acceleration.
    That's under Tools -> Preferences -> (Simple) -> Input/Codecs -> Hardware-accelerated decoding

    Changing the hardware acceleration to something other than d3d11 might work too - it fixed the green screen for me but the plugin stopped working for some reason, but maybe it will continue working for you?

  2. Enable d3d11_filters video filters.
    Go to Tools -> Preferences -> (All) -> Video -> Filters and look for filters with "D3D11" in name. I think there are 2 of them, both enabling the same d3d11_filters plugin, so it's enough to tick any one of them, or both.

    For some reason d3d11_filters shows up in the module list even if it's disabled, but explicitly enabling them makes it show up twice (and also doubles the GPU usage...) - once before the plugin and then once after it, which for some reason fixes the issue.

Use just one workaround, using both doesn't make sense (I don't think you can even use d3d11_filters with the hardware acceleration disabled).

commented

The bug must me somewhere outside the plugin, in VLC or its dependencies, given how even a simple no-op video filter plugin causes this:

#include <vlc_common.h>
#include <vlc_filter.h>
#include <vlc_plugin.h>

static int Create(vlc_object_t *);
static void Destroy(vlc_object_t *);

vlc_module_begin()
    set_description("Noop video filter")
    set_shortname("Noop video filter")
    set_capability("video filter", 0)
    set_category(CAT_VIDEO)
    set_subcategory(SUBCAT_VIDEO_VFILTER)
    set_callbacks(Create, Destroy)
vlc_module_end()

static picture_t *filter(filter_t *p_filter, picture_t *p_pic_in)
{
    // don't alter picture
    return p_pic_in;
}

static int Create(vlc_object_t *p_this)
{
    filter_t *p_filter = (filter_t *)p_this;
    p_filter->pf_video_filter = filter;
    return VLC_SUCCESS;
}

static void Destroy(vlc_object_t *p_this)
{
}

I have poked developers on IRC, will see what they say.

Ideally I'd open a bug report, but I can't as they require to provide logs and I don't have access to the computer that reproduces this to provide them. Even if I did get the logs, VLC developers would likely suggest to try changing some settings in VLC and see if that helps, which I can't do without having access to the computer that reproduces this.

Perhaps one of you could file a bug report instead? If you do, it would be better if you do so using the noop video filter the code of which I have posted above, as it triggers the same bug with less code. Here are dlls for it:

It shows up as "Noop video filter" under video filters.

commented

Mentioned the workarounds in README's Troubleshooting section.

commented

I encountered this issue on my laptop however it was triggered while navigating DVD navigation menus. once the video started playing tho it worked normally but I could not see most of the menu or chapter selections. The workaround in my opinion is not a valid fix as your basically saying don't use the GPU you paid for use whatever hot garbage intel shoved into the CPU that only exists to push pre-rendered frames from the REAL GPU to the screen or HDMI port. my laptop will drag on anything 1080p or higher if the nvidia acceleration is disabled because of how weak the integrated graphics are

commented

I experience the same problem.
When I enable plugin and run DVD the menu plays OK.
But when I select option "Play movie" it shows only green screen and video doesn't work.
This is plugin issue, it is a bug .
No such plugin should brake video playback.
If it doesn't work for DVD, then it means it was poorly tested before the release.

commented

Closing comments as the discussion of this issue has been exhausted.

I have asked earlier that if you are able to reproduce this bug -- file a bug report with VLC, as it appears to be a bug in VLC rather than the plugin, and I'm unable to reproduce it with my Intel iGPU, so I won't be able to provide any logs or anything like that if I file the bug report myself. As far as I know, so far no one has filed a bug report with VLC. Since no one seems to be willing to help fix this bug, I have filed the bug report myself just now https://trac.videolan.org/vlc/ticket/25057.

commented

An update.

I became an owner of an Nvidia GPU recently, so I was able to reproduce the bug. From my testing, there are a few things I have observed:

  • This bug appears to be triggered by interlaced videos. The first interlaced video will play just fine, but any interlaced video after that will have this green picture bug.
  • It is a bug in VLC, not vlc-pause-click-plugin, as even the built-in "FPS conversion video filter" triggers the bug.

I have shared my findings and logs with the VLC team, hopefully they can pin down the bug and fix it.

I implemented a workaround for the bug (at the cost of a slight efficiency loss), allowing vlc-pause-click-plugin to work with interlaced videos without turning them green. I intended to use that workaround until the VLC team properly fixes the bug, at which point I would remove the workaround, but the workaround triggered yet another bug with interlaced videos, so my workaround can't be used until VLC fixes that second bug.

Scrapping the workaround, I implemented a compromise: disable vlc-pause-click-plugin on interlaced videos on Windows -- this would prevent VLC from breaking itself with the green picture. Alas, this compromise implementation was foiled by how VLC detects interlaced videos -- if you play an interlaced video, no matter if the next video is interlaced or not, VLC will treat is as interlaced for 30 seconds, at which point it will change its mind if it is, in fact, not interlaced. So vlc-pause-click-plugin ends up being disabled for the first 30 seconds of a progressive, i.e. non-interlaced, video, that is played after an interlaced video, and then it gets enabled after those 30 seconds end, which is quite a jarring user experience, so this compromise was also scrapped.

I'm out of ideas on how this bug can be addressed on the plugin level. These are bugs in VLC and need to be addressed on the VLC level. So we will have to wait on the VLC team to fix the mentioned bugs until there is anything we can do.

commented

The bug appears to be fixed in the nightly VLC 4.0, unable to reproduce the bug using that version. Sadly, it's unlikely that it will get fixed in VLC 3.0.