Search (by author) results contains invalid links

[Google Code Exporter]

Repro instructions valid as of August 14:

1. Type "muumi" into search box
2. Notice you get three links to "nightwish fail" (only one works), one 
"nightwish" that links to the 
attachment

Probably our additional search thingabob doesn't require post_status=publish 
etc.

Original issue reported on code.google.com by [e-mail] on 14 Aug 2008 at 3:52

[Google Code Exporter]

Seems it's not only the publish status.  It also shows links to attachments, 
e.g.

http://www.saasta.fi/saasta/?attachment_id=3662

Original comment by [e-mail] on 17 Aug 2008 at 10:15

[Google Code Exporter]

Well, the problem is in our search plugin. I tried messing with the SQL and 
might've fixed it, but it's somewhat 
messy.

Anyway, I took Jaska Keko's Search Tags plugin, rewrote the query and rebranded 
the bastard as Saasta 
Search. I'm basically overriding whatever WP has in the SQL WHERE clause to 
suit our needs. However, the end 
result is almost identical to our old SQL queries.

The thing is, I'm not sure what would be the best way to search stuff. I guess 
the main things we want to 
search for are title, content, tags and authors? What about searches like "tag 
tag author"? It gets somewhat 
complicated depending on what we want to support. Currently my plugin seems 
(note that I'm not too 
confident yet ;)) to search either by author, tags or title&content, but it's 
not possible to combine them.

I also looked at two search plugins, Search Everything and Search Unleashed. 
The latter was crap and returned 
NOTHING after installation. The former (SE) has all sorts of options but it 
doesn't search for authors, nor does 
it search for more than one tag.

Original comment by [e-mail] on 21 Aug 2008 at 5:49

[Google Code Exporter]

IMO we should set design goals for our own search with the mindset that Google 
is our
primary search method.  Whatever is hard to accomplish (or too imprecise) with 
Google
should be dealt with our own search.

If it turns out our own search adds no value over Google, we could replace the 
whole
thing with Google's own search box which would then do 
"site:www.saasta.fi/saasta
<xyzzy>".

Original comment by [e-mail] on 21 Aug 2008 at 7:01