nurpax / saastafi

Automatically exported from code.google.com/p/saastafi

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Recent faves doesn't include my previous "add fave"

GoogleCodeExporter opened this issue · comments

What steps will reproduce the problem?
1. Add a fave on live site to a post
2. Observe the recent faves list 

What is the expected output? What do you see instead?

I'd expect the post to appear on the fave list.  It didn't.

At the moment, you can see Kalle's bender post on saasta which is not
listed in recent faves even though it was just faved.

Original issue reported on code.google.com by jjhel...@gmail.com on 13 Apr 2008 at 7:43

Oh crapness, what a stuuuuuuuupid bug. It did work actually, but the "show only 
first 5 results" part of the 
query didn't work.

Well now it does. Also changed the DB structure for faves a bit, not 100% sure 
if it was necessary but at least 
everything works now.

Original comment by mikko.ur...@gmail.com on 14 Apr 2008 at 6:35

  • Changed state: Fixed
Re-opening.

After uploading the fixed code on saasta, I now get duplicate entries in the 
recently
faved region:

#
Recent faves

    * Frenchmen and dogs (1)
    * Om yom yom (3)
    * Jallu commercial!! (4)
    * Jallu commercial!! (4)
    * Jallu commercial!! (4)


Original comment by jjhel...@gmail.com on 28 Apr 2008 at 6:07

  • Changed state: Accepted
Btw whoever chooses to fix this, please look at issue 51 when closing.  It 
seems to
be a duplicate of this.

Original comment by jjhel...@gmail.com on 28 Apr 2008 at 6:08

Assign to Q2 milestone.

Original comment by jjhel...@gmail.com on 28 Apr 2008 at 6:08

  • Added labels: Milestone-2008-Q2
Hopefully fixed in r234. 

Had to alter the functionality a bit - now the SQL bit is rather simple and 
post title and permalink fetching is 
left to WP. Also couldn't immediately find a way to get the "number of faves" 
appended at the end of the title, 
guess we can live without that for the time being.

Oh yeah, _IF_ it still doesn't work, you might need to fire up this in saasta's 
mysql:

alter table saasta_faves change fave_date fave_date timestamp not null default 
current_timestamp on update 
current_timestamp;

Original comment by mikko.ur...@gmail.com on 11 Aug 2008 at 3:34

Did you do any hacks on the DB schema via MySQL client?  If so, let me know so 
I can
add those changes into the saasta.fi plugin.  All the DB alterations should be 
done
with PHP code so that the schema is automatically created for new sites upon
installation.

Res for fixing!

Original comment by jjhel...@gmail.com on 11 Aug 2008 at 4:22

No, like my comment (#5) says: "Oh yeah, _IF_ it still doesn't work, you might 
need to fire up this in saasta's 
mysql..."

Not sure if fave_date is part of your PHP shenanigans, other sites were not 
discussed when I added that in the 
first place, and I've had nothing to do with them ever so...

Original comment by mikko.ur...@gmail.com on 12 Aug 2008 at 7:37

I've copied the MySQL table creation to PHP side based on the MySQL schema I 
found on
the live server.  I took it about 1.5 months ago so I'd say it's working as 
expected.

Don't worry about other sites, I can review new changes and see what if they 
break
under my subsite hackery or not.

Original comment by jjhel...@gmail.com on 12 Aug 2008 at 7:53

Ok well I'm closing this then.

Original comment by mikko.ur...@gmail.com on 13 Aug 2008 at 11:49

  • Changed state: Verified