Giters

nulab / scala-oauth2-provider

OAuth 2.0 server-side implementation written in Scala

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

clientSecret should be Option

tsuyoshizawa opened this issue · comments

commented

clientId of AuthInfo has wrapped Option class by Make client credentials optional password #34 to not have empty string. I think this way is correct on Scala.

clientSecret of ClientCredential also might have empty string by ClientCredentialFetcher.

So I would like to change the clientSecret of ClientCredential to Option[String].

commented

Hi Tsuyoshi, when do you expect to finalize the 0.10.0 release? I've been using the 0.10.0 snapshot build which you keep improving but that means I need to keep modifying my integration accordingly. For now I've saved a local copy of the 0.10.0 snapshot so am fine, but am curious about your release plans.

commented

@ctoomey I plan to release 0.10.0 version this weekend!