New default of prompting to strip whitespace
rdonkin opened this issue · comments
Great plugin, thank you for writing and maintaining it!
I would prefer the plugin not to change its behaviour by default - when I got a prompt just now for the first time since upgrading, it was quite a surprise (wasn't even aware plugins could do this).
How about keeping the default of g:strip_whitespace_confirm as 0, so behaviour doesn't change from older versions?
Hi @rdonkin, indeed @toejough (in #69) also reported issues with the change of behaviour. Sorry for that.
I guess the rationale was that for new users it makes more sense to have it prompt by default, but of course that doesn't apply to seasoned users. I guess the ideal would have been to be able to display a message on updating, to make users aware of the new features/defaults/settings, but I'm not sure how to do that nor if that's extremely welcome in a vim plugin.
@ntpeters is looking at disabling confirmation by default (i.e. restoring legacy behaviour) and also checking &confirm.
I came across this same thing upon updating, and really I don't think anybody would ever want to be prompted about this. Disabling the prompt by default is probably the way to go, or maybe just removing the feature completely.
I'm a new user of this plugin (also new to Vim but not stripping white space).
I like that you need to enable strip on save, but having to set a confirmation in addition to that feels a bit much IMO. If you're explicitly setting strip on save it's ok to trust the user that we know what we're getting into.
Other than that, the plugin works great, thanks!