ntop / ntopng

Environment:

OS name: opnsense
OS version: FreeBSD 14.1
Architecture: amd64
ntopng version/revision: v.6.3.240813

What happened:

After upgrading from ntopng 6.0 Community, the DSCP Selector dropdown no longer renders while viewing active flows. Yet, when an integer value for a DSCP tag (CS4==32 or CS5==40) is provided as a query parameter in the URL as such https://ntopng/lua/flows_stats.lua?flowhosts_type=&...&dscp=32, the flows are correctly filtered by their DSCP value similar to ntopng 6.0 behavior.

How did you reproduce it?

ntopng/scripts/lua/flows_stats.lua

Lines 190 to 192 in 9a35ae5

    
           if (dscp_filter ~= nil) then 
        
               page_params["dscp"] = dscp_filter 
        
           end

ntopng/scripts/lua/flows_stats.lua

Line 293 in 9a35ae5

printActiveFlowsDropdown(base_url, page_params, ifstats, flowstats)

ntopng/scripts/lua/modules/flow_utils.lua

Lines 2474 to 2482 in 9a35ae5

    
           -- DSCP selector 
        
           -- table.clone needed to modify some parameters while keeping the original unchanged 
        
           local dscp_params = table.clone(page_params) 
        
           dscp_params["dscp"] = nil 
        
           print [[, '<div class="btn-group float-right">]] 
        
           printDSCPDropdown(base_url, dscp_params, flowstats["dscps"] or {}, format_utils) 
        
           print [[</div>']]

Debug Information:

the issue should now be fixed, in a couple of hours update and let me know

Just tried out the flow_filter.lua patch. My DSCP tags are reported in the dropdown and able to be filtered again.

	if (dscp_filter ~= nil) then
	page_params["dscp"] = dscp_filter
	end

	-- DSCP selector
	-- table.clone needed to modify some parameters while keeping the original unchanged
	local dscp_params = table.clone(page_params)
	dscp_params["dscp"] = nil

	print [[, '<div class="btn-group float-right">]]
	printDSCPDropdown(base_url, dscp_params, flowstats["dscps"] or {}, format_utils)
	print [[</div>']]