nteract / commuter

🚎 Notebook sharing hub

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Default value for COMMUTER_S3_ENDPOINT shouldn't be an empty string

elvinx opened this issue · comments

I am trying to use commuter with s3 and if I don't set COMMUTER_S3_ENDPOINT the default is

var s3Endpoint = env.COMMUTER_S3_ENDPOINT || ""

this causes

rror: connect ECONNREFUSED 127.0.0.1:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1129:14) {
  message: 'connect ECONNREFUSED 127.0.0.1:443',
  errno: -61,
  code: 'NetworkingError',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 443,
  region: 'us-east-1',
  hostname: '',
  retryable: true,
  time: 2020-06-23T10:28:51.483Z
} Error: connect ECONNREFUSED 127.0.0.1:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1129:14)

However it works fine if it is set to null.

Thanks for reporting this issue, @elvinx!

Would you like to submit a pull request with a fix for this?