Download and Open buttons should do different actions for text and binary

Question

Download and Open buttons should do different actions for text and binary

532910 opened this issue a year ago · comments

sergio commented a year ago

Roman Khimov commented a year ago

#26

Mike Petrov · Answer 1 · Mon May 22 2023 21:37:57 GMT+0800 (China Standard Time)

There a get request is sent which returns the file with its name. In case we just follow the link, we see the file with the name equal to the object id.

sergio · Answer 2 · Mon May 22 2023 22:42:17 GMT+0800 (China Standard Time)

I know of course.

same actions must be done in the same ways
this must not be a button, but a link (though it can look as a button)

Mike Petrov · Answer 3 · Mon May 22 2023 22:45:36 GMT+0800 (China Standard Time)

But it's not a link, why can't it be a button?

sergio · Answer 4 · Mon May 22 2023 22:54:16 GMT+0800 (China Standard Time)

https://css-tricks.com/buttons-vs-links/

Mike Petrov · Answer 5 · Mon May 22 2023 22:57:23 GMT+0800 (China Standard Time)

Ok, but after #23 it is a button now, because there not any links there. Right?

sergio · Answer 6 · Mon May 22 2023 23:10:36 GMT+0800 (China Standard Time)

not sure if I correctly understand what has been changed

Roman Khimov · Answer 7 · Tue May 23 2023 00:05:25 GMT+0800 (China Standard Time)

I guess we need to update send.fs.neo.org to the current master version. @aprasolova, can you do this?

Anastasia Prasolova · Answer 8 · Tue May 23 2023 00:21:51 GMT+0800 (China Standard Time)

@roman-khimov done, please check

sergio · Answer 9 · Tue May 23 2023 00:52:16 GMT+0800 (China Standard Time)

nothing has changed

Anastasia Prasolova · Answer 10 · Tue May 23 2023 00:56:14 GMT+0800 (China Standard Time)

Well, I've deleted the previous files and uploaded the new ones. So wonderful it would be to have a commit hash on a site page, wouldn't it, @mike-petrov and @roman-khimov?

Mike Petrov · Answer 11 · Tue May 23 2023 01:09:52 GMT+0800 (China Standard Time)

I think so, create issue. The current version is uploaded I checked. @532910, you can check

sergio · Answer 12 · Tue May 23 2023 03:20:52 GMT+0800 (China Standard Time)

nothing has changed

Mike Petrov · Answer 13 · Tue May 23 2023 03:24:17 GMT+0800 (China Standard Time)

Now, when you click Download btn downloading process on this page, without open new tab, you check that?

sergio · Answer 14 · Tue May 23 2023 04:28:05 GMT+0800 (China Standard Time)

both do the same: open file in the current page

Mike Petrov · Answer 15 · Tue May 23 2023 04:36:17 GMT+0800 (China Standard Time)

What's browser did you use? I don't have this behaviour.
I my case:

Download btn - downloading file on current page
Open file by link - opening file i new tab

sergio · Answer 16 · Tue May 23 2023 14:32:51 GMT+0800 (China Standard Time)

my browsers fucks Content-Disposition, but this doesn't breaks github for example:

download button saves file and Raw opens in the same tab

In your case, if I upload text, both button open it (download in the same tab, link in a new tab), if I upload binary -- both actions just do the same: save file.

sergio · Answer 17 · Tue May 23 2023 14:33:16 GMT+0800 (China Standard Time)

btw, what is the reason for opening a new tab?

Mike Petrov · Answer 18 · Tue May 23 2023 16:30:32 GMT+0800 (China Standard Time)

Opening a new tab in the same way as in the previous version of sendfs. As for this issue, Download btn should be a button component without shown url, right?

As for the difference between download and open file by link, in case uploading specific files like binary/doc/docx/... it not possible to see it in browser, thats why browser download them. But it works properly for most of the cases with text files. What solution do you see?