ESC considered to be F1 in keyboard events

Question

ESC considered to be F1 in keyboard events

QingYun opened this issue 8 years ago · comments

Hi! I'm new here and I'm trying to make the output demo work in a GNOME terminal. The while loop in the main function clearly shows that it should exit when the ESC key is pressed, but it doesn't work. I always get a 0xFFFF as ev.key instead of TB_KEY_ESC.

I believe the problem is in the extract_event, which calls parse_escape_seq when the first character of the input buffer is ESC. The parse_escape_seq will then find this single-character buffer matches the first sequence in the keys array, which is F1.

I added a len > 1 condition above the call to parse_escape_seq as a workaround. Not sure if I've done anything wrong as such a fundamental feature should be broken.

nsf · Answer 1 · Fri Sep 23 2016 00:45:44 GMT+0800 (China Standard Time)

I probably should revert this patch: 6dfe8a0

Right? What do you think?

nsf · Answer 2 · Fri Sep 23 2016 00:48:55 GMT+0800 (China Standard Time)

Sorry for applying that patch without properly testing it.