nschloe / matplotx

:bar_chart: More styles and useful extensions for Matplotlib

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove some typing hint to support older numpy ?

ProV1denCEX opened this issue · comments

Hello, I got an error ModuleNotFoundError: No module named 'numpy.typing' due to the typing hint from numpy.typing import ArrayLike.

Would you mind remove this hint to support older numpy version like 1.19.* ? It seems no performance issue after remove it.

What python version are you using?

python 3.7.8 with numpy 1.19.5

So why don't you upgrade to numpy 1.20? They support Python 3.7+.

cz many other packages like pytorch require a numpy version <=1.19.*
and I don't think removing typing hint is a breaking change for matplotx.

cz many other packages like pytorch require a numpy version <=1.19.*

I just installed torch with numpy 1.21, no problem.