nrwl / nx

Smart Monorepos · Fast CI

Home Page:https://nx.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Inconsistency between Rust and Node hashers

MJez29 opened this issue · comments

Current Behavior

I am seeing the rust hasher incorrectly expand the !**/__test?(s)__/**/* input to !**/*__/**/*, !**/__tests__/**/* which is causing false-positive cache hits when using nx affected on a change within a folder like __private__

Expected Behavior

I expect this to expand to !**/__test__/**/*, !**/__tests__/**/*. This matches the behaviour of the Node hasher

GitHub Repo

https://github.com/MJez29/nx-rust-hasher-bug

Steps to Reproduce

Please follow the commands in the README
https://github.com/MJez29/nx-rust-hasher-bug?tab=readme-ov-file#nxrusthasherbug

Nx Report

Node   : 20.12.2
OS     : darwin-arm64
npm    : 10.5.0

nx                 : 19.4.2
@nx/js             : 19.4.2
@nx/linter         : 19.4.2
@nx/eslint         : 19.4.2
@nx/workspace      : 19.4.2
@nx/devkit         : 19.4.2
@nx/eslint-plugin  : 19.4.2
@nrwl/tao          : 19.4.2
@nx/vite           : 19.4.2
@nx/web            : 19.4.2
typescript         : 5.4.5

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response