npow / airline-codes

An NPM module containing airline codes (IATA) and other information

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bad Callsign / Country

teamcoltra opened this issue · comments

There are 61 entries with a space before the entry for "callsign". These correlate to the callsign and country being wrong. I'm guessing these were imported improperly from another data source and not caught. I'll work on a fix for this.

Also I think we should change the format from "alias":"\N", to a more standard "alias":"", which would save space and also fit with how all the other empty fields are. This might need to be another issue but this project seems quiet enough to have them both here.

I've created pull requests for my fixes, I didn't actually pull the repo and do everything I just fixed it within Github so it created two separate requests.

Oh and I left "Private Flight" as #1 because it's in the initial data and maybe now someone is using it for something, but maybe that should be removed since I think it's just meaning "Private Flight" as in a non-commercial flight not an airline (especially based on the other data). So that's not something that probably should be in airlines.json.

#15 #16 are my pulls