Does not return if the command is not executable by user's primary group
whs opened this issue · comments
Manatsawin Hanmongkolchai commented
Steps to reproduce:
sudo chmod o-x /usr/bin/make
sudo chown root:sudo /usr/bin/make
- Run a
node-gyp build
from a user who is a member of groupsudo
, butsudo
is not his primary group
(Tested on Debian 6.0.8)
node-gyp will complain about missing make
, even if make
is in fact executable by current user.
isaacs commented
Yes, we need to check against all the results from process.getgroups()
if the function is available. Patch welcome.