New minor version 1.3.7 introduces a breaking changes

Question

New minor version 1.3.7 introduces a breaking changes

ThomasKientz opened this issue 4 years ago · comments

Use of Object.create(null) in this commit breaks the use of hasOwnProperty() by other packages depending on this one.

Eg : jonschlinkert/git-user-email#5

I am suggesting a rollback and publishing that change as a major version bump instead.

isaacs · Answer 1 · Sat Dec 12 2020 03:58:51 GMT+0800 (China Standard Time)

Ack, good catch, sorry about that.

Fixed on 1.3.8, I'll publish a v2 shortly that re-introduces the change. (For what it's worth, relying on obj.hasOwnProperty is a bit brittle anyway, because someone could put a hasOwnProperty field in the ini file itself.)