Improved CI process
ynnoj opened this issue Β· comments
Appears that yarn test
is only ran as part of the release workflow against the default branches (main
, beta
).
We should introduce CI for all PRs to ensure:
- The package builds.
- Tests pass.
We can use on.pull_request
with a separate workflow file to build and test the package.
@notrab Are you happy for me to draft a PR for this?
@ynnoj yep! PR and merge at will.
Here's what I had previously https://github.com/notrab/react-use-cart/pull/56/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88 which (could be improved?) and it was mistakenly removed π
π This issue has been resolved in version 1.11.1 π
The release is available on:
Your semantic-release bot π¦π