Template API Documentation + SMS Processing

[medcelerate]

It would be great t have documentation on what values are exposed to liquid in what contexts. I have also noticed that with 1.3.0 it doesn't seem to evaluate the notification.body for sms templates, only the subject. For loops also render as text and are not computed.

[Sebastian Stehle]

Yes, makes sense. In another project I just created an endpoint for that, which can then be used in an integrated help and for auto completion.

[medcelerate]

Is there somewhere in the code I can look for for the current injectable parameters? Also the sms templates seem to fully ignore the message body param.

…

On Sun, Mar 31, 2024 at 3:11 PM Sebastian Stehle ***@***.***> wrote: Yes, makes sense. In another project I just created an endpoint for that, which can then be used in an integrated help and for auto completion. — Reply to this email directly, view it on GitHub <#230 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHYKRGKIJXBNIKTOFXGYJDLY3BNUJAVCNFSM6AAAAABFP4XSUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYHA4DAMBSHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Sebastian Stehle]

In the latest version it is much more unified: https://github.com/notifo-io/notifo/blob/main/backend/src/Notifo.Domain/Liquid/LiquidContext.cs

But in 1.3.0 it is only this one: https://github.com/notifo-io/notifo/blob/1.3.0/backend/src/Notifo.Domain/Channels/Sms/SmsFormatter.cs#L53, which also has not changed that much: https://github.com/notifo-io/notifo/blob/1.2.0/backend/src/Notifo.Domain/Channels/Sms/SmsFormatter.cs

[medcelerate]

I’ll update to latest and see if that resolves the sms body being blank

…

On Sun, Mar 31, 2024 at 4:00 PM Sebastian Stehle ***@***.***> wrote: In the latest version it is much more unified: https://github.com/notifo-io/notifo/blob/main/backend/src/Notifo.Domain/Liquid/LiquidContext.cs But in 1.3.0 it is only this one: https://github.com/notifo-io/notifo/blob/1.3.0/backend/src/Notifo.Domain/Channels/Sms/SmsFormatter.cs#L53, which also has not changed that much: https://github.com/notifo-io/notifo/blob/1.2.0/backend/src/Notifo.Domain/Channels/Sms/SmsFormatter.cs — Reply to this email directly, view it on GitHub <#230 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHYKRGIDKPXTK52IDGFN6D3Y3BTM5AVCNFSM6AAAAABFP4XSUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYHA4TANBTG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Sebastian Stehle]

You have to use the current dev version.

[medcelerate]

Got it, I’ll migrate over

…

On Sun, Mar 31, 2024 at 4:12 PM Sebastian Stehle ***@***.***> wrote: You have to use the current dev version. — Reply to this email directly, view it on GitHub <#230 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHYKRGLMKQHKPEI3HUGV4ITY3BU4PAVCNFSM6AAAAABFP4XSUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYHA4TGNRSGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[medcelerate]

Seems like there is a validation error with the current dev version on the sms page, saying text field is required but the API request is sending the text field.

[Sebastian Stehle]

I have fixed that.

[medcelerate]

Is it in a new build that has this fix? I'm using the latest from notifo-dev.

[Sebastian Stehle]

Should be part of the notifo-dev:1481 tag.

[medcelerate]

Yes, fixed, thanks!

[Sebastian Stehle]

I pushed an improvement where I added a list of properties to sms template page with some other fixes.