notea-org / notea

📒 Self hosted note taking app stored on S3

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Feature Request] Password-protected encrypted notes

Tarsenicum opened this issue · comments

Hi!
How about adding some privacy-related features?
For example, password-protected notes.
Example use case: you're stepped away and accidentally forgot to lock your desktop. Then everyone can access your very important notes.
Next case is a password leak. Everything is clear here, I think.

Of course, such notes must be encrypted in storage.

Some considerations for implementation:
Re-ask login password
Configure some master-password
Configure password for each protected note

commented

Hiya! Sorry for the late reply - I've been quite busy with IRL stuff and more commercial endeavours since doing open source does not pay my bills.

I like this idea, but I think your description has some flaws:

  1. What is clear, specifically? The implementation details, the example case's effect, or what comes thereafter?
    In essence, I don't find everything clear at all.
  2. Presuming my interpretation of the example use case is what you intended - if you go away from your desktop, Notea doesn't really have a way of detecting that.
    The closest thing would be to check when focus is lost from the app, but that happens too often (e.g. when there are multiple windows open that you switch between frequently).
  3. The "password leak" part would really not be a fault of Notea. Storing passwords in local text files is incredibly bad practice - let alone storing them in a publicly accessible web app.
    Even then, a greater security risk is the password managers you use - for example, if you use Firefox's built-in password manager without setting a primary/master password (which is the default if memory serves me), anyone could easily access your passwords if you step away from your desktop.
  4. If a malicious actor has access to the storage where you've configured Notea to store the notes, then you're plain doing something wrong.
    I'm not saying having Notea encrypting the notes is a bad idea (although there are issues with this too), but the storage should only be accessible by administrators/hosts.

Then there's also the issue of how you would do if you want to have backups - should Notea decrypt the notes, or should they stay encrypted? How do password-protected notes get decrypted? How should Notea check if the passwords are correct? How do you handle password-protected notes that are shared?
There are tons of questions like these that just hinder this from becoming a viable feature, at least in the near future.

Another problem is that I'm trying to keep the original vision that Qingwei had (at least from what I can gather). This included having Notea be simple which after setting it up I find it succeeds at. This feature would not mesh well with the goal of simplicity.