Giters

notaryproject / notation-go

A collection of libraries for supporting sign and verify OCI artifacts. Based on Notary Project specifications.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Behavior of VerifyOptions.MaxSignatureAttempts

patrickzheng200 opened this issue · comments

commented

This issue tracks the behavior of VerifyOptions.MaxSignatureAttempts during notation.Verify(). As of 11//22/2022, we will have the following logics:

  1. Default of VerifyOptions.MaxSignatureAttempts is 0, when a user decides to use default, notation.Verify() would verify unlimited number of signatures associated with the artifact.
  2. User gives a positive number to VerifyOptions.MaxSignatureAttempts, notation.Verify() would verify at most VerifyOptions.MaxSignatureAttempts number of signatures associated with the artifact.
  3. User gives a negative number to VerifyOptions.MaxSignatureAttempts, same behavior as case 1.

@shizhMSFT @yizha1 @priteshbandi @rgnote Please leave your concerns/comments/suggestions if there's any.

commented

Should we use 0 and -ve to default for unlimited or user can pass math.MaxInt64 which is unlimited for all practical purpose?

If we use later, it simplifies our code logic and makes it more readable for caller

commented

Closed this issue since we decided to not make change to current behavior in notation-go. In notation CLI, we will pass in a large number such as math.MaxInt64 as unlimited.