Proposal: Reduce the required number of approvals to `1`

Question

Proposal: Reduce the required number of approvals to `1`

shizhMSFT opened this issue a year ago · comments

It is currently not reasonable to have 2 approvals for merging a PR where we only have 3 repo-level maintainers and one of them is the PR author.

Therefore, I propose that we should reduce the required number of approvals before merging from 2 to 1 for the notation-action repo. Once we have more repo-level maintainers, we can revert the change.

Yi Zha commented a year ago

LGTM

Pritesh Bandi commented a year ago

LGTM

Josh Duffney commented a year ago

LGTM

Toddy Mladenov · Answer 1 · Sat Jul 22 2023 00:55:07 GMT+0800 (China Standard Time)

LGTM. I went ahead and modified the requirement to 1 approval