All packages with phase WAITING show customs icon
ristomatti opened this issue · comments
Special icon for packages waiting for customs declaration was my feature request but it's appeared the logic to show it on WAITING phase doesn't seem to be adequate. WAITING phase seems to be used also for packages waiting for pickup from the sender.
Maybe this could be fixed with an additional check for the delivery status? Unfortunately I don't have any such package right now to get the status text but I have one bigger package from China coming and it likely will get stuck in customs. I can update the issue if/when that happens.
Update: the package got stuck in customs as expected. But it made this even more complicated. The package now shows:
- "in transport" icon instead of customs icon
- package details show it can already be picked up even though the latest status "Lähetys on rekisteröity" with the phase
IN_TRANSPORT.
I'm out of ideas how to best solve this. This the first time the customs icon does not appear so this might be some special snowflake case. Any ideas @norkator?
Update: the package got stuck in customs as expected. But it made this even more complicated. The package now shows:
- "in transport" icon instead of customs icon
- package details show it can already be picked up even though the latest status "Lähetys on rekisteröity" with the phase
IN_TRANSPORT.I'm out of ideas how to best solve this. This the first time the customs icon does not appear so this might be some special snowflake case. Any ideas @norkator?
Send me your tracking code IF possible at Trello, I want to see my own eyes what is going on.
Okay my notes about this case are:
This is shown because API is providing this information already and we don't have handling with this banner + current phase, do we want that?
As said parcel is in customs with state IN_TRANSPORT
We use only newest status to determine does it need customs handling but:
now there is never status saying this.. I am out of ideas. Parsing every event line to determine customs handling is too dangerous.
This seems like a mess. I agree it sounds too hacky to go through all the statutes for the customs status. It might be simpler to just put the feature behind a disabled feature flag for now until we get more examples?
Closing for now. Open back if we see something happening to this.