Dionysus breaks InventoryClickEvent
opened this issue · comments
Describe the bug
https://pastes.dev/KMii60ImRB
a rare error, I met 2-4 times
Plugins
[21:08:06 INFO]: Plugins (26): antiRedstoneClock, AuthMe, ChatCo, ChatSentinel, CommandWhitelist, DeathMessages, HelpCommand, IllegalStack, InvSeePlusPlus, KillCommand, LibertyBans, LuckPerms, MiniMOTD, nAntiBot, NoCheatPlus, PebbleAntiVPN, PlaceholderAPI, ProtocolLib, SkinsRestorer, spark, TAB, UTitleAuth, ViaBackwards, ViaRewind, ViaVersion, Worldstats
Version
[21:08:19 INFO]: This server is running Dionysus version git-Dionysus-"f459cb0" (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT)
Reaper/Paper - errors do not occur
удали нахер istaсk - это самый говеный плагин создающий кучу дюпов и крашей
от него у тебя кстати и краши
удали нахер istaсk - это самый говеный плагин создающий кучу дюпов и крашей
у меня все чеки отключены там кроме энда и бедрока
от него у тебя кстати и краши
нцп тоже орал
попробуй обновить нцп, так как он тебе пишет, что не может найти класс.
попробуй обновить нцп, так как он тебе пишет, что не может найти класс.
2 плагина одновременно?
и да, все обновлены
удали нахер istaсk - это самый говеный плагин создающий кучу дюпов и крашей
ты прав
удали нахер istaсk - это самый говеный плагин создающий кучу дюпов и крашей
ты прав
иче юзать
This is returning null because this.slots is hitting a ArrayIndexOutOfBoundsException which may be due to another change and Alex never triaged it further back than adding a try catch exception.
This is returning null because this.slots is hitting a ArrayIndexOutOfBoundsException which may be due to another change and Alex never triaged it further back than adding a try catch exception.
you can fix?
This is returning null because this.slots is hitting a ArrayIndexOutOfBoundsException which may be due to another change and Alex never triaged it further back than adding a try catch exception.
you can fix?
I need a reproduction case or without that, I have to guess at reproduction steps which could take forever.
This is returning null because this.slots is hitting a ArrayIndexOutOfBoundsException which may be due to another change and Alex never triaged it further back than adding a try catch exception.
you can fix?
I need a reproduction case or without that, I have to guess at reproduction steps which could take forever.
ok, i deleting this patch to fix error, yeah? https://github.com/nopjmp/Dionysus
https://github.com/nopjmp/Dionysus/blob/dev/patches/server/0159-Prevent-IndexOutOfBound-in-window-packet.patch
This is returning null because this.slots is hitting a ArrayIndexOutOfBoundsException which may be due to another change and Alex never triaged it further back than adding a try catch exception.
you can fix?
I need a reproduction case or without that, I have to guess at reproduction steps which could take forever.
ok, i deleting this patch to fix error, yeah? https://github.com/nopjmp/Dionysus https://github.com/nopjmp/Dionysus/blob/dev/patches/server/0159-Prevent-IndexOutOfBound-in-window-packet.patch
Look further back in the log, you have IndexOutOfBounds Exceptions in the logs. Do you have those on other implementations?
. Do you have those on other implementations?
what implementations?
Reaper/Paper - errors do not occur
Reaper/Paper - errors do not occur
[20:29:16 FATAL]: Error executing task
java.util.concurrent.ExecutionException: java.lang.IndexOutOfBoundsException: Index 58 out of bounds for length 46
at java.util.concurrent.FutureTask.report(Unknown Source) ~[?:?]
at java.util.concurrent.FutureTask.get(Unknown Source) ~[?:?]
at net.minecraft.server.v1_12_R1.SystemUtils.a(SourceFile:47) ~[patched_1.12.2.jar:git-Dionysus-"f459cb0"]
at net.minecraft.server.v1_12_R1.MinecraftServer.D(MinecraftServer.java:866) ~[patched_1.12.2.jar:git-Dionysus-"f459cb0"]
at net.minecraft.server.v1_12_R1.DedicatedServer.D(DedicatedServer.java:429) ~[patched_1.12.2.jar:git-Dionysus-"f459cb0"]
at net.minecraft.server.v1_12_R1.MinecraftServer.C(MinecraftServer.java:790) ~[patched_1.12.2.jar:git-Dionysus-"f459cb0"]
at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:681) ~[patched_1.12.2.jar:git-Dionysus-"f459cb0"]
at java.lang.Thread.run(Unknown Source) ~[?:?]
Caused by: java.lang.IndexOutOfBoundsException: Index 58 out of bounds for length 46
at jdk.internal.util.Preconditions.outOfBounds(Unknown Source) ~[?:?]
at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Unknown Source) ~[?:?]
at jdk.internal.util.Preconditions.checkIndex(Unknown Source) ~[?:?]
at java.util.Objects.checkIndex(Unknown Source) ~[?:?]
at java.util.ArrayList.get(Unknown Source) ~[?:?]
at net.minecraft.server.v1_12_R1.Container.a(Container.java:263) ~[patched_1.12.2.jar:git-Dionysus-"f459cb0"]
at net.minecraft.server.v1_12_R1.PlayerConnection.a(PlayerConnection.java:2103) ~[patched_1.12.2.jar:git-Dionysus-"f459cb0"]
at net.minecraft.server.v1_12_R1.PacketPlayInWindowClick.a(SourceFile:33) ~[patched_1.12.2.jar:git-Dionysus-"f459cb0"]
at net.minecraft.server.v1_12_R1.PacketPlayInWindowClick.a(SourceFile:10) ~[patched_1.12.2.jar:git-Dionysus-"f459cb0"]
at net.minecraft.server.v1_12_R1.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:14) ~[patched_1.12.2.jar:git-Dionysus-"f459cb0"]
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:?]
at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:?]
at net.minecraft.server.v1_12_R1.SystemUtils.a(SourceFile:46) ~[patched_1.12.2.jar:git-Dionysus-"f459cb0"]
Sounds like a exploit windowclick