nomcopter / react-mosaic

A React tiling window manager

Home Page:https://nomcopter.github.io/react-mosaic/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Strict mode support

gempir opened this issue · comments

It would be nice if react-mosaic supported React strict mode without warnings. findDOMNode is deprecated in strict mode and should be replaced with a reference.

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Blueprint3.ResizeSensor which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://fb.me/react-strict-mode-find-node

image

image

  • Package version(s): 4.1.1
  • Browser and OS versions: Ubuntu 20.04 Chrome 85

Steps to reproduce

  1. Use Strict Mode https://reactjs.org/docs/strict-mode.html
  2. Add a new split
  3. Check the console

This looks like a bug on Blueprint 3. There are no usages of findDomNode in react-mosaic and Blueprint is an optional dependency.