Do not run make test in docker image build
33Fraise33 opened this issue · comments
Hello,
You have a line:
this makes the build take way longer than needed as each build always includes the tests.
Es this something that is done on purpose and is this a general best practice?
I also do not understand why you would run the builder seperately in the makefile:
OSSMediator/ElasticsearchPlugin/Makefile
Line 13 in 3b253ac
if you are planning to run docker it does not make sense as you can just get the plugin or collector binaries like:
sudo docker run -it --volumes-from=ossmediator --entrypoint=/bin/sh ossmediatorcollector:latest -i
Hi Gianni, Thanks for the input.
I've made the changes in develop branch and added make docker_build process for building without test cases.
make all : Will run both build and test
make docker_build: Will only run build process
PR: #40
Please check.
Looks good I think ;)
Closing the issue.