nodemcu / nodemcu-firmware

Lua based interactive firmware for ESP8266, ESP8285 and ESP32

Home Page:https://nodemcu.readthedocs.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

RFC: Connect automatic test system with CI Builds

HHHartmann opened this issue · comments

Missing feature

Automatic testing is a great feature and CI builds are as well. But automatically trigger the tests from the CI build is even greater.

Justification

Better stability of the product

I would like to discuss whether we should use a self hosted runner or create another solution.

Self hosted runners allow to run github actions on a local machine. That would be a relatively easy way to get the artefacts which we build in CI builds anyways to a local machine and use them for testing.

The disadvantage is that this imposes a potential risk as each PR can contain an action definition with arbitrary code which would be executed on the local machine.
See https://docs.github.com/en/free-pro-team@latest/actions/hosting-your-own-runners/about-self-hosted-runners#self-hosted-runner-security-with-public-repositories for details

The question is to either

  • make the local machine isolated enough to not have to care
  • ignore the risks
  • find some other solution
commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.