Giters

nodejs / unofficial-builds

Unofficial binaries for Node.js

Home Page:https://unofficial-builds.nodejs.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

v22.0.0 build failed

nschonni opened this issue · comments

commented

I think it ran the x86 build, then crashed out if I'm reading the logs right https://unofficial-builds.nodejs.org/logs/202404241830-v22.0.0/build.log

commented

Yeah, here is the x86 logs and its definitely failing: https://unofficial-builds.nodejs.org/logs/202404241830-v22.0.0/x86.log

commented

x86 looks broken and someone will need to look at it. Maybe the container and/or compiler will need to be updated, or there might be a real issue with x86 in V8.

I've requeued the remaining recipes:

./bin/queue-push.sh -v v20.0.0 -r musl -r x64-glibc-217 -r armv6l -r loong64 -r riscv64 -r x64-pointer-compression -r x64-debug

(FYI I'm not going to be around to babysit these through.)

commented

Oh, @richardlau I'm now seeing that you requeued v20 rather than v22. Not sure if that's going to cause an issue with the old images if the SHAs get updated for that old release

commented

erk. Good catch. I've killed off the running processes/queued stuff and requeued for 22:

$ ./bin/queue-push.sh -v v22.0.0 -r musl -r x64-glibc-217 -r armv6l -r loong64 -r riscv64 -r x64-pointer-compression -r x64-debug
Queuing v22.0.0 with recipes: musl,x64-glibc-217,armv6l,loong64,riscv64,x64-pointer-compression,x64-debug
$
commented

armv6l uses a too old GCC

commented

Although there may be architectures that are still failing, I'm going to close this one since the main issue of the build filing is addressed. If there are specific architecture issues that are going to persist in v22, it's probably good to spin up issues and disable them until they can be addressed

commented

Isn't this going to be the case for the next v22 release though? should the x86 build be moved down the list to prevent this happening again?

commented

https://github.com/nodejs/unofficial-builds/blob/main/recipes/armv6l/should-build.sh this should be fixed to stop it building >= 22, does someone here want to give that a go?

then, if someone wants to make this work again, they can put in the work to get the compiler upgraded, but as of today, it'd be on me and I'm very unlikely to do this any time soon

commented

@rvagg yep! On it!

commented

armv6l uses a too old GCC

shouldn't armv6l be disabled instead of x86? @LaurentGoderre

commented

@DanielSchuech the primary issue at this point is preventing the failing x86 from interfering with the next v22 release. I believe @rvagg was sending that file as an example on how to control the build.

commented

Both x86 and armv6l builds failed for Node.js 22.0.0.

commented

Opened #143 for the armv6l by copying the other PR

commented

Thanks for the explanation. I only had a look into the latest log folder where no x86.log was present.

commented

Thanks for the explanation. I only had a look into the latest log folder where no x86.log was present.

Yes, because I didn't queue x86 since it failed in the original attempt.

commented

thanks for the two should-run changes @LaurentGoderre & @nschonni

If anyone wants to tackle armv6l, the path I'd take is to just produce a new https://github.com/rvagg/rpi-newer-crosstools with a the minimum compiler and libc needed to support node. It looks like there's newer crosstools-ng that support up to gcc 13 so it shouldn't be too hard. I think I explain the process in that repo about taking an existing config and running a newer crosstools-ng and picking new versions.