nodejs / nodejs.org

The Node.js® Website

Home Page:https://nodejs.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Improve inactive codebox tab text on light mode

bmuenzenmeyer opened this issue · comments

Lighthouse is dinging us for poor contrast here

This is only in light mode

image

in our system design the codebox has a light style, why we don't apply it?
I think the discussion has already taken place but I can't find it.

the search input appears to have the same contrast issue too.

image

the search input appears to have the same contrast issue too.

image

I feel that the search input one was intentional, but indeed it does not pass accessibility tests. We should fix it!

in our system design the codebox has a light style, why we don't apply it?

we decided to only have one. it might have been shikiji-related?

we decided to only have one. it might have been shikiji-related?

it would be cool to have both but i'm willing to bet it will increase the bundle size